Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN-376 Add contributors and note to language variants #279

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

huluvu21
Copy link
Contributor

Motivation

The goal is to support contributors and notes in language variants. This includes the enhancement of "change-workflow" endpoint that where the due date was also added.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@huluvu21 huluvu21 requested review from pokornyd and a team as code owners December 10, 2024 12:11
pokornyd
pokornyd previously approved these changes Jan 30, 2025
Copy link
Member

@pokornyd pokornyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR mentions only due date being added to Change workflow endpoint, but it appears much more's been added in the end. nothing wrong with that, just wanted to clarify the extent the endpoint is being modified and if it's retaining its name in API reference (otherwise the underlying method should likely be renamed too). suggested a minor formatting change, otherwise looks good

@pokornyd pokornyd merged commit bf987e3 into kontent-ai:master Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants